139 remove ipgetter#140
Open
Castronova wants to merge 4 commits into
Open
Conversation
martin-hunt
reviewed
Oct 31, 2018
martin-hunt
left a comment
martin-hunt
left a comment
There was a problem hiding this comment.
Looks fine.
Could also remove unused modules appdirs, pyparsing and six
sblack-usu
reviewed
Nov 1, 2018
| import logging | ||
| import tornado.auth | ||
| import shutil | ||
| import ipgetter |
There was a problem hiding this comment.
so, this is just removing an unused library and formatting changes?
There was a problem hiding this comment.
The ipgetter module no longer exists, so this dependency breaks the build. It is also not used, so removing it does not affect anything.
sblack-usu
approved these changes
Nov 1, 2018
martin-hunt
approved these changes
Nov 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed ipgetter library from JH REST server which was causing docker builds to fail